Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 22 Apr 2016 18:43:13 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12961614.1461325902000.11489.1461350593159@Atlassian.JIRA>
In-Reply-To: <JIRA.12961614.1461325902000@Atlassian.JIRA>
References: <JIRA.12961614.1461325902000@Atlassian.JIRA>
 <JIRA.12961614.1461325902102@arcas>
Subject: [jira] [Commented] (HBASE-15693) Reconsider the ImportOrder rule of
 checkstyle
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15254442#comment-15254442 ] 

stack commented on HBASE-15693:
-------------------------------

+1

Be careful config'ing checkstyle. I've not had good luck with it. Build was broke on commit. Easy to check for post-commit.

> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>
>                 Key: HBASE-15693
>                 URL: https://issues.apache.org/jira/browse/HBASE-15693
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>              Labels: checkstyle
>         Attachments: HBASE-15693.patch
>
>
> I have been confused many times with the wrong import order checkstyle warnings in the pre commit result. And I haven't found any developer guide which tells me what is the right order so this time I decided to read the rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which can only work with option 'top' or 'bottom'(which means place static imports on top or bottom) and use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to 'top'.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)