Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 009F51903E for ; Tue, 19 Apr 2016 01:16:26 +0000 (UTC) Received: (qmail 23338 invoked by uid 500); 19 Apr 2016 01:16:25 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 23287 invoked by uid 500); 19 Apr 2016 01:16:25 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 23146 invoked by uid 99); 19 Apr 2016 01:16:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Apr 2016 01:16:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 8E19D2C1F62 for ; Tue, 19 Apr 2016 01:16:25 +0000 (UTC) Date: Tue, 19 Apr 2016 01:16:25 +0000 (UTC) From: "Mikhail Antonov (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15658) RegionServerCallable / RpcRetryingCaller clear meta cache on retries MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246904#comment-15246904 ] Mikhail Antonov commented on HBASE-15658: ----------------------------------------- Looks good to me, +1. (in some next patches we should also try to remove these 'reload' and 'useCache' flags, they complicate logic and make the changes fragile IMO) > RegionServerCallable / RpcRetryingCaller clear meta cache on retries > -------------------------------------------------------------------- > > Key: HBASE-15658 > URL: https://issues.apache.org/jira/browse/HBASE-15658 > Project: HBase > Issue Type: Sub-task > Components: Client > Affects Versions: 1.2.1 > Reporter: Gary Helmling > Assignee: Gary Helmling > Priority: Critical > Fix For: 1.3.0 > > Attachments: hbase-15658.001.patch > > > When RpcRetryingCaller.callWithRetries() attempts a retry, it calls RetryingCallable.prepare(tries != 0). For RegionServerCallable (and probably others), this will wind up calling RegionLocator.getRegionLocation(reload=true), which will drop the meta cache for the given region and always go back to meta. > This is kind of silly, since in the case of exceptions, we already call RetryingCallable.throwable(), which goes to great pains to only refresh the meta cache when necessary. Since we are already doing this on failure, I don't really understand why we are doing duplicate work to refresh the meta cache on prepare() at all. -- This message was sent by Atlassian JIRA (v6.3.4#6332)