Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2BD3419E81 for ; Wed, 13 Apr 2016 03:45:26 +0000 (UTC) Received: (qmail 99335 invoked by uid 500); 13 Apr 2016 03:45:26 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 99285 invoked by uid 500); 13 Apr 2016 03:45:26 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 99262 invoked by uid 99); 13 Apr 2016 03:45:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Apr 2016 03:45:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C12AC2C1F5C for ; Wed, 13 Apr 2016 03:45:25 +0000 (UTC) Date: Wed, 13 Apr 2016 03:45:25 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15636) hard coded wait time out value in HBaseTestingUtility#waitUntilAllRegionsAssigned might cause test failure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238549#comment-15238549 ] Hudson commented on HBASE-15636: -------------------------------- SUCCESS: Integrated in HBase-1.2-IT #484 (See [https://builds.apache.org/job/HBase-1.2-IT/484/]) HBASE-15636 hard coded wait time out value in (syuanjiangdev: rev cdf56ec93997e141aef4681f67d8f22dbfe854a1) * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java > hard coded wait time out value in HBaseTestingUtility#waitUntilAllRegionsAssigned might cause test failure > ---------------------------------------------------------------------------------------------------------- > > Key: HBASE-15636 > URL: https://issues.apache.org/jira/browse/HBASE-15636 > Project: HBase > Issue Type: Bug > Components: integration tests, test > Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.4 > Reporter: Stephen Yuan Jiang > Assignee: Stephen Yuan Jiang > Priority: Minor > Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.5, 1.2.2 > > Attachments: HBASE-15636.v1-master.patch > > > HBaseTestingUtility#waitUntilAllRegionsAssigned(final TableName tableName) hard coded 60 seconds wait for region assignment in a table. This could cause flaky tests, as the caller could create table with longs of region which takes longs time; or in CM, RS unavailable could slow down assignment; or in a slow machine, IT might take long to assign regions. > In HBaseAdmin.java, we use a configurable value to wait for the table DDLs: {{this.syncWaitTimeout = this.conf.getInt("hbase.client.sync.wait.timeout.msec", 10 * 60000); // 10min}} - we should use the config for the HBaseTestingUtility#waitUntilAllRegionsAssigned() too. > Of course, the caller could use the "public void waitUntilAllRegionsAssigned(final TableName tableName, final long timeout)"; but it requires test change (currently, no test directly calls this signature). > {code} > /** > * Wait until all regions for a table in hbase:meta have a non-empty > * info:server, up to 60 seconds. This means all regions have been deployed, > * master has been informed and updated hbase:meta with the regions deployed > * server. > * @param tableName the table name > * @throws IOException > */ > public void waitUntilAllRegionsAssigned(final TableName tableName) throws IOException { > waitUntilAllRegionsAssigned(tableName, 60000); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)