Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 524F519637 for ; Mon, 11 Apr 2016 21:07:26 +0000 (UTC) Received: (qmail 59767 invoked by uid 500); 11 Apr 2016 21:07:26 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 59728 invoked by uid 500); 11 Apr 2016 21:07:26 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 59700 invoked by uid 99); 11 Apr 2016 21:07:26 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Apr 2016 21:07:26 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id C3A972C1F5C for ; Mon, 11 Apr 2016 21:07:25 +0000 (UTC) Date: Mon, 11 Apr 2016 21:07:25 +0000 (UTC) From: "huaxiang sun (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15632) Undo the checking of lastStoreFlushTimeMap.isEmpty() introduced in HBASE-13145 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] huaxiang sun updated HBASE-15632: --------------------------------- Status: Patch Available (was: Open) > Undo the checking of lastStoreFlushTimeMap.isEmpty() introduced in HBASE-13145 > ------------------------------------------------------------------------------ > > Key: HBASE-15632 > URL: https://issues.apache.org/jira/browse/HBASE-15632 > Project: HBase > Issue Type: Improvement > Components: regionserver > Affects Versions: 2.0.0 > Reporter: huaxiang sun > Assignee: huaxiang sun > Priority: Minor > Attachments: HBASE-15632-v001.patch > > > HBASE-13145 introduce the following check > {code} > diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > index 215069c..8f73af5 100644 > --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java > @@ -1574,7 +1574,8 @@ public class HRegion implements HeapSize, PropagatingConfigurationObserver { // > */ > @VisibleForTesting > public long getEarliestFlushTimeForAllStores() { > - return Collections.min(lastStoreFlushTimeMap.values()); > + return lastStoreFlushTimeMap.isEmpty() ? Long.MAX_VALUE : Collections.min(lastStoreFlushTimeMap > + .values()); > } > {code} > I think the reason for the check is that table creation without family is allowed before HBASE-15456. With HBASE-15456, table creation without family is not allowed. We have one user claimed that they run into the same HRegionServer$PeriodicMemstoreFlusher exception, and the table was created with family. The log was not kept so could not find more info there. By checking the code, it seems impossible. Can we undo this check so the real issue is not hidden in case there is one, [~Apache9]? -- This message was sent by Atlassian JIRA (v6.3.4#6332)