Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 527BF189EA for ; Mon, 25 Apr 2016 04:36:13 +0000 (UTC) Received: (qmail 58064 invoked by uid 500); 25 Apr 2016 04:36:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 58004 invoked by uid 500); 25 Apr 2016 04:36:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 57988 invoked by uid 99); 25 Apr 2016 04:36:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Apr 2016 04:36:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D813E2C1F62 for ; Mon, 25 Apr 2016 04:36:12 +0000 (UTC) Date: Mon, 25 Apr 2016 04:36:12 +0000 (UTC) From: "stack (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15477) Do not save 'next block header' when we cache hfileblocks MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-15477: -------------------------- Attachment: 15477.backport.branch-1.v2.patch Rebase > Do not save 'next block header' when we cache hfileblocks > --------------------------------------------------------- > > Key: HBASE-15477 > URL: https://issues.apache.org/jira/browse/HBASE-15477 > Project: HBase > Issue Type: Sub-task > Components: BlockCache, Performance > Reporter: stack > Assignee: stack > Fix For: 2.0.0 > > Attachments: 15366v4.patch, 15477.backport.branch-1.patch, 15477.backport.branch-1.v2.patch, 15477.patch, 15477v2.patch, 15477v3.patch, 15477v3.patch, 15477v4.patch > > > When we read from HDFS, we overread to pick up the next blocks header. > Doing this saves a seek as we move through the hfile; we save having to > do an explicit seek just to read the block header every time we need to > read the body. We used to read in the next header as part of the > current blocks buffer. This buffer was then what got persisted to > blockcache; so we were over-persisting wrtiting out our block plus the > next blocks' header (overpersisting 33 bytes). Parse of HFileBlock > complicated by this extra tail. Fix. -- This message was sent by Atlassian JIRA (v6.3.4#6332)