Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 25A7819910 for ; Sat, 30 Apr 2016 00:23:13 +0000 (UTC) Received: (qmail 85858 invoked by uid 500); 30 Apr 2016 00:23:13 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 85812 invoked by uid 500); 30 Apr 2016 00:23:13 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 85744 invoked by uid 99); 30 Apr 2016 00:23:12 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 30 Apr 2016 00:23:12 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CD2C82C1F5C for ; Sat, 30 Apr 2016 00:23:12 +0000 (UTC) Date: Sat, 30 Apr 2016 00:23:12 +0000 (UTC) From: "Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265005#comment-15265005 ] Ted Yu commented on HBASE-15357: -------------------------------- With patch for branch-1, TestTableInputFormatScan1#testGetSplitsPoint currently fails. > TableInputFormatBase getSplitKey does not handle signed bytes correctly > ----------------------------------------------------------------------- > > Key: HBASE-15357 > URL: https://issues.apache.org/jira/browse/HBASE-15357 > Project: HBase > Issue Type: Bug > Components: mapreduce > Reporter: Nathan Schile > Assignee: Nathan Schile > Fix For: 2.0.0, 1.4.0 > > Attachments: 15357-branch-1.v2.txt, 15357.v2.txt, HBASE-15357.patch > > > When auto-balance is enabled in TableInputFormatBase and the table key is a binary key, the getSplitKey method does not function correctly for signed bytes. The proposed solution it to utilize org.apache.hadoop.hbase.util.Bytes#split method to find the split key. org.apache.hadoop.hbase.util.Bytes#split is stated to be a expensive operation, so if another solution is preferred, that is fine. In addition, handling of a split key that is equal to the TableSplit end key is added to calculateRebalancedSplits. -- This message was sent by Atlassian JIRA (v6.3.4#6332)