hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15693) Reconsider the ImportOrder rule of checkstyle
Date Sun, 24 Apr 2016 14:03:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255593#comment-15255593
] 

Hudson commented on HBASE-15693:
--------------------------------

SUCCESS: Integrated in HBase-1.4 #114 (See [https://builds.apache.org/job/HBase-1.4/114/])
HBASE-15693 Reconsider the ImportOrder rule of checkstyle (zhangduo: rev 2e55f8436693208187f772381f790510a8307cd0)
* hbase-checkstyle/src/main/resources/hbase/checkstyle.xml


> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>
>                 Key: HBASE-15693
>                 URL: https://issues.apache.org/jira/browse/HBASE-15693
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.0.3, 1.1.4, 0.98.19, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>              Labels: checkstyle
>             Fix For: 2.0.0, 1.3.0, 1.0.4, 1.4.0, 1.1.5, 1.2.2, 0.98.20
>
>         Attachments: HBASE-15693-0.98.patch, HBASE-15693-branch-1.0.patch, HBASE-15693-branch-1.1.patch,
HBASE-15693-branch-1.2.patch, HBASE-15693-branch-1.3.patch, HBASE-15693-branch-1.patch, HBASE-15693.patch
>
>
> I have been confused many times with the wrong import order checkstyle warnings in the
pre commit result. And I haven't found any developer guide which tells me what is the right
order so this time I decided to read the rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which can only
work with option 'top' or 'bottom'(which means place static imports on top or bottom) and
use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to 'top'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message