hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15693) Reconsider the ImportOrder rule of checkstyle
Date Sat, 23 Apr 2016 10:35:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255226#comment-15255226

Duo Zhang commented on HBASE-15693:

[~busbey] Only master? Seems the checkstyle.xml in other branches are different from the one
in master?


> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>                 Key: HBASE-15693
>                 URL: https://issues.apache.org/jira/browse/HBASE-15693
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>              Labels: checkstyle
>         Attachments: HBASE-15693.patch
> I have been confused many times with the wrong import order checkstyle warnings in the
pre commit result. And I haven't found any developer guide which tells me what is the right
order so this time I decided to read the rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which can only
work with option 'top' or 'bottom'(which means place static imports on top or bottom) and
use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to 'top'.

This message was sent by Atlassian JIRA

View raw message