hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15693) Reconsider the ImportOrder rule of checkstyle
Date Sat, 23 Apr 2016 08:31:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255207#comment-15255207
] 

Duo Zhang commented on HBASE-15693:
-----------------------------------

Before
{noformat}
[INFO] There are 5 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 6 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 1330 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 46 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 2879 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 8 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 70 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 138 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 6911 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 107 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 305 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 613 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 26 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
{noformat}

After
{noformat}
[INFO] There are 5 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 6 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 1321 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 46 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 2875 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 8 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 70 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 138 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 6887 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 103 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 305 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 612 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
[INFO] There are 26 errors reported by Checkstyle 6.11.2 with hbase/checkstyle.xml ruleset.
{noformat}

12444 vs. 12402

[~busbey]

> Reconsider the ImportOrder rule of checkstyle
> ---------------------------------------------
>
>                 Key: HBASE-15693
>                 URL: https://issues.apache.org/jira/browse/HBASE-15693
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>              Labels: checkstyle
>         Attachments: HBASE-15693.patch
>
>
> I have been confused many times with the wrong import order checkstyle warnings in the
pre commit result. And I haven't found any developer guide which tells me what is the right
order so this time I decided to read the rule by myself.
> In the ImportOrder section, we declare sortStaticImportsAlphabetically which can only
work with option 'top' or 'bottom'(which means place static imports on top or bottom) and
use the default option which is 'under'.
> I prefer placing static import on top, so I suggest here we set option to 'top'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message