hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15664) Use Long.MAX_VALUE instead of HConstants.FOREVER in CompactionPolicy
Date Mon, 18 Apr 2016 06:09:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245182#comment-15245182
] 

Duo Zhang commented on HBASE-15664:
-----------------------------------

[~tedyu] Seems no problem on branch-1?

Let me wait for the result of 0.98. Will commit if no problem too.

Thanks.

> Use Long.MAX_VALUE instead of HConstants.FOREVER in CompactionPolicy
> --------------------------------------------------------------------
>
>                 Key: HBASE-15664
>                 URL: https://issues.apache.org/jira/browse/HBASE-15664
>             Project: HBase
>          Issue Type: Bug
>          Components: Compaction
>    Affects Versions: 2.0.0, 1.3.0, 0.98.19, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 1.3.0, 0.98.19, 1.4.0
>
>         Attachments: HBASE-15664-0.98.patch, HBASE-15664-branch-1.patch, HBASE-15664-branch-1.v1.patch,
HBASE-15664-v1.patch, HBASE-15664-v2.patch, HBASE-15664.patch
>
>
> The TTL per CF is in seconds, we will convert it to milliseconds when construct HStore.
And if it is HConstants.FOREVER, we will set it to Long.MAX_VALUE.
> {code:title=HStore.java}
>   public static long determineTTLFromFamily(final HColumnDescriptor family) {
>     // HCD.getTimeToLive returns ttl in seconds.  Convert to milliseconds.
>     long ttl = family.getTimeToLive();
>     if (ttl == HConstants.FOREVER) {
>       // Default is unlimited ttl.
>       ttl = Long.MAX_VALUE;
>     } else if (ttl == -1) {
>       ttl = Long.MAX_VALUE;
>     } else {
>       // Second -> ms adjust for user data
>       ttl *= 1000;
>     }
>     return ttl;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message