hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Warhaftig (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15615) Wrong sleep time when RegionServerCallable need retry
Date Tue, 12 Apr 2016 00:03:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236282#comment-15236282
] 

Matt Warhaftig commented on HBASE-15615:
----------------------------------------

Hi [~zghaobac], Thanks for finding this bug and submitting a patch.  I had actually glanced
at this ticket before you grabbed it and noticed that some of the other classes implementing
RetryingCallable (ex MasterCallable) do not do tries +1 and so was thinking about if all implementation
should have tries +1.

Anyway, this is just a stream of consciousness question from my head, so please disregard
if you know better. :-). 

Cheers,
Matt

> Wrong sleep time when RegionServerCallable need retry
> -----------------------------------------------------
>
>                 Key: HBASE-15615
>                 URL: https://issues.apache.org/jira/browse/HBASE-15615
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Guanghao Zhang
>            Assignee: Guanghao Zhang
>         Attachments: HBASE-15615.patch
>
>
> In RpcRetryingCallerImpl, it get pause time by expectedSleep = callable.sleep(pause,
tries + 1); And in RegionServerCallable, it get pasue time by sleep = ConnectionUtils.getPauseTime(pause,
tries + 1). So tries will be bumped up twice. And the pasue time is 3 * hbase.client.pause
when tries is 0.
> RETRY_BACKOFF = {1, 2, 3, 5, 10, 20, 40, 100, 100, 100, 100, 200, 200}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message