hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15605) Remove PB references from HCD and HTD for 2.0
Date Thu, 07 Apr 2016 11:10:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230096#comment-15230096
] 

Anoop Sam John commented on HBASE-15605:
----------------------------------------

ColumnFamilySchema convertToColumnFamilySchema(byte[] name, Map<Bytes, Bytes> values,
	      Map<String, String> conf) 
Better pass HCD to this method and return ColumnFamilySchema. The other do the reverse way.
convertToColumnFamilySchema, convert  -> Can the naming be consistent?
Same for HTD related 2 methods

Regarding not using the empty constructor now.  That will be no issue I believe.  It will
do some unwanted ops but no logical issue as such I guess. Now the private constructor in
HCD is of no use and can be removed?

> Remove PB references from HCD and HTD for 2.0
> ---------------------------------------------
>
>                 Key: HBASE-15605
>                 URL: https://issues.apache.org/jira/browse/HBASE-15605
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15605.patch
>
>
> This task is sub-task for HBASE-15174. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message