hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15584) Revisit handling of BackupState#CANCELLED
Date Fri, 08 Apr 2016 16:58:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232483#comment-15232483
] 

Ted Yu commented on HBASE-15584:
--------------------------------

Vlad made the following response on review board w.r.t. cancelBackup() command (https://reviews.apache.org/r/45729/diff/1/?file=1325585#file1325585line80):

bq. How? Does procedure automatically shutdown M/R jobs in progress?

> Revisit handling of BackupState#CANCELLED
> -----------------------------------------
>
>                 Key: HBASE-15584
>                 URL: https://issues.apache.org/jira/browse/HBASE-15584
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Priority: Minor
>
> During review of HBASE-15411, Enis made the following point:
> {code}
> nobody puts the backup in cancelled state. setCancelled() is not used. So if I abort
a backup, who writes to the system table the new state? 
> Not sure whether this is a phase 1 patch issue or due to this patch. We can open a new
jira and address it there if you do not want to do it in this patch. 
> Also maybe this should be named ABORTED rather than CANCELLED.
> {code}
> This issue is to decide whether this state should be kept (e.g. through notification
from procedure V2 framework in response to abortion).
> If it is to be kept, the state should be renamed ABORTED.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message