hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15579) Remove synchronized around nonce in Procedure submit
Date Mon, 11 Apr 2016 22:38:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15236118#comment-15236118
] 

Matteo Bertozzi commented on HBASE-15579:
-----------------------------------------

yeah, but the IDs are not really supposed to be user sequential. 
you'll see that especially with sub-procedures. 

e.g. create may have procId=1, and you run disable after it may have procId=10 where the 9
missing are for assignment sub-procedures.

> Remove synchronized around nonce in Procedure submit
> ----------------------------------------------------
>
>                 Key: HBASE-15579
>                 URL: https://issues.apache.org/jira/browse/HBASE-15579
>             Project: HBase
>          Issue Type: Sub-task
>          Components: proc-v2
>    Affects Versions: 2.0.0, 1.2.0, 1.3.0, 1.1.4
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0, 1.3.0, 1.1.5, 1.2.2
>
>         Attachments: HBASE-15579-v0.patch
>
>
> There is a synchronized in ProcedureExecutor.submitProcedure() that protect the nonce
insert. We can get rid of that and just use the nonce concurrent map pufIfMissing



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message