hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15572) Adding optional timestamp semantics to HBase-Spark
Date Fri, 08 Apr 2016 16:40:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232461#comment-15232461

Sean Busbey commented on HBASE-15572:

(1) The name follows the convention of existing HBaseSparkConf. But you are right, we may
want to use hbase.spark instead of spark.hbase. I think it would be better to solve it with
a separate JIRA to change all these names in one shot instead of introducing name inconsistency.

There are already both "hbase.spark" and "spark.hbase" entries in HBaseSparkConf and a ticket
for correcting the "spark.hbase" ones (HBASE-15597).

Please do not make the problem worse. Please correct your use of constant keys before this
patch goes in. To be clear, I won't +1 this patch without either a technical justification
for needing the "spark.hbase" version or correcting it.

(2) Regarding the document JIRA, it does have some loose dependency, e.g., JSON format, etc,
DataFrame Rread/Writer, etc. Otherwise, it is hard to explain the usage in a clear way. For
Zhan Zhang has already created jira HBASE-15473, I think it is better to add more explanation
on that jira.

Your added test does not appear to rely on the currently undocumented additions, unless I'm
missing it? If you like, we can make HBASE-15473 a blocker for this to make sure the prerequisites
are in place?

> Adding optional timestamp semantics to HBase-Spark
> --------------------------------------------------
>                 Key: HBASE-15572
>                 URL: https://issues.apache.org/jira/browse/HBASE-15572
>             Project: HBase
>          Issue Type: New Feature
>          Components: spark
>            Reporter: Weiqing Yang
>            Assignee: Weiqing Yang
>             Fix For: 2.0.0
>         Attachments: HBASE-15572-1.patch, HBASE-15572-2.patch, HBASE-15572-3.patch, HBASE-15572-4.patch,
HBASE-15572-5.patch, HBASE-15572-6.patch, HBASE-15572-7.patch, HBASE-15572-8.patch, HBASE-15572-9.patch
> Right now the timestamp is always latest. With this patch, users can select timestamps
they want.
> In this patch, 4 parameters, "timestamp", "minTimestamp", "maxiTimestamp" and "maxVersions"
are added to HBaseSparkConf. Users can select a timestamp, they can also select a time range
with minimum timestamp and maximum timestamp. A new test for selecting records with different
timestamps is added.

This message was sent by Atlassian JIRA

View raw message