hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yu Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15537) Add multi WAL support for AsyncFSWAL
Date Sat, 02 Apr 2016 13:39:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222891#comment-15222891
] 

Yu Li commented on HBASE-15537:
-------------------------------

+1, patch lgtm. Have tried the newly added UT case locally and all could pass.

One minor code format issue in {{RegionGroupingProvider}} (I introduced it in v2 patch, sorry):
{noformat}
+    for (WALProvider provider: cached.values()) {
+      try {
+      provider.shutdown();
+      } catch (IOException e) {
+        LOG.error("Problem shutting down wal provider '" + provider + "': " + e.getMessage());
{noformat}

> Add multi WAL support for AsyncFSWAL
> ------------------------------------
>
>                 Key: HBASE-15537
>                 URL: https://issues.apache.org/jira/browse/HBASE-15537
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15537-v3.patch, HBASE-15537.patch, HBASE-15537_v2.patch
>
>
> The multi WAL should not be bound with {{FSHLog}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message