hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15536) Make AsyncFSWAL as our default WAL
Date Tue, 26 Apr 2016 07:57:13 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15257711#comment-15257711

Duo Zhang commented on HBASE-15536:

Ah an annoying problem with TestHRegion.testDurability...

In this test we create a spied WAL and the Mockito,spy will create a copy of the object passed
in. The problem is AsyncFSWAL.consumer, it is an instance of an inner class and hold a reference
to the outside AsyncFSWAL object. The copied AsyncFSWAL object just the same instance of consumer
with original AsyncFSWAL object, so it is still reference the original AsyncFSWAL, not the
copied one. This introduce some logic errors and cause our UT hanging forever...

Will change it to use FSHLog since this is not test for WAL implementation.

> Make AsyncFSWAL as our default WAL
> ----------------------------------
>                 Key: HBASE-15536
>                 URL: https://issues.apache.org/jira/browse/HBASE-15536
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>         Attachments: HBASE-15536.patch
> As it should be predicated on passing basic cluster ITBLL

This message was sent by Atlassian JIRA

View raw message