hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianwei Cui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15497) Incorrect javadoc for atomicity guarantee of Increment and Append
Date Sun, 10 Apr 2016 06:43:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233922#comment-15233922

Jianwei Cui commented on HBASE-15497:

Can anyone help to review the patch? Thanks:)

> Incorrect javadoc for atomicity guarantee of Increment and Append
> -----------------------------------------------------------------
>                 Key: HBASE-15497
>                 URL: https://issues.apache.org/jira/browse/HBASE-15497
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.0.0
>            Reporter: Jianwei Cui
>            Priority: Minor
>         Attachments: HBASE-15497-v1.patch
> At the front of {{Increment.java}} file, there is comment about read atomicity:
> {code}
>  * This operation does not appear atomic to readers.  Increments are done
>  * under a single row lock, so write operations to a row are synchronized, but
>  * readers do not take row locks so get and scan operations can see this
>  * operation partially completed.
> {code}
> It seems this comment is not true after MVCC integrated [HBASE-4583|https://issues.apache.org/jira/browse/HBASE-4583].
Currently, the readers can be guaranteed to read the whole result of Increment if I am not
wrong. Similar comments also exist in {{Append.java}}, {{Table#append(...)}} and {{Table#increment(...)}}

This message was sent by Atlassian JIRA

View raw message