hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15357) TableInputFormatBase getSplitKey does not handle signed bytes correctly
Date Sat, 30 Apr 2016 00:23:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15265005#comment-15265005
] 

Ted Yu commented on HBASE-15357:
--------------------------------

With patch for branch-1, TestTableInputFormatScan1#testGetSplitsPoint currently fails.

> TableInputFormatBase getSplitKey does not handle signed bytes correctly
> -----------------------------------------------------------------------
>
>                 Key: HBASE-15357
>                 URL: https://issues.apache.org/jira/browse/HBASE-15357
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>            Reporter: Nathan Schile
>            Assignee: Nathan Schile
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: 15357-branch-1.v2.txt, 15357.v2.txt, HBASE-15357.patch
>
>
> When auto-balance is enabled in TableInputFormatBase and the table key is a binary key,
the getSplitKey method does not function correctly for signed bytes. The proposed solution
it to utilize org.apache.hadoop.hbase.util.Bytes#split method to find the split key. org.apache.hadoop.hbase.util.Bytes#split
is stated to be a expensive operation, so if another solution is preferred, that is fine.
In addition, handling of a split key that is equal to the TableSplit end key is added to calculateRebalancedSplits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message