hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hiroshi Ikeda (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15292) Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction
Date Fri, 08 Apr 2016 09:47:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231940#comment-15231940

Hiroshi Ikeda commented on HBASE-15292:

Actually can PendingWatcher be omitted ?
If you means embedding an anonymous class instead PendingWatcher, I think the code becomes
a little messy, doesn't it?

> Refined ZooKeeperWatcher to prevent ZooKeeper's callback while construction
> ---------------------------------------------------------------------------
>                 Key: HBASE-15292
>                 URL: https://issues.apache.org/jira/browse/HBASE-15292
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>            Reporter: Hiroshi Ikeda
>            Assignee: Hiroshi Ikeda
>            Priority: Minor
>         Attachments: HBASE-15292-V2.patch, HBASE-15292-V3.patch, HBASE-15292-V4.patch,
> The existing code is not just messy but also contains a subtle bug of visibility due
to missing synchronization between threads.
> The root of the evil is that ZooKeeper uses a silly anti-pattern, starting a thread within
its constructor, and in practice all the developers are not allowed to use ZooKeeper correctly
without tedious code.

This message was sent by Atlassian JIRA

View raw message