hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15278) AsyncRPCClient hangs if Connection closes before RPC call response
Date Thu, 28 Apr 2016 11:11:12 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15261967#comment-15261967
] 

Duo Zhang commented on HBASE-15278:
-----------------------------------

Seems the latest patch still modifies AsyncRpcChannel? But you said above that the patch only
contains a new testcase? [~chenheng]

Could you explain why we can get a exception other than the injected one? We need to rewrite
the tests if it does not always throw the expected exception...

And I think the patch of HBASE-15520 has something wrong... We should call channel.close(null)
in AsyncServerResponseHandler.channelnactive. The close method of AsyncRpcChannel will create
a ConnectionClosingException if the exception passed in is null. You can include this modification
in your patch here. Sorry, my fault...

Thanks. 

> AsyncRPCClient hangs if Connection closes before RPC call response 
> -------------------------------------------------------------------
>
>                 Key: HBASE-15278
>                 URL: https://issues.apache.org/jira/browse/HBASE-15278
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Priority: Blocker
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15278.patch, hbase-15278_v00.patch
>
>
> The test for HBASE-15212 discovered an issue with Async RPC Client. 
> In that test, we are closing the connection if an RPC call writes a call larger than
max allowed size, the server closes the connection. However the async client does not seem
to handle connection closes with outstanding RPC calls. The client just hangs. 
> Marking this blocker against 2.0 since it is default there. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message