hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
Date Thu, 07 Apr 2016 03:53:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229630#comment-15229630
] 

ramkrishna.s.vasudevan commented on HBASE-15174:
------------------------------------------------

I completed my analysis and all these items. Few are straight forward and few can be directly
removed. 
But regarding the ones that depend on the PB's enum for different states, like Admin getCompactionState()
which returns the PB compaction state - we need to maintain a correpsonding state POJO or
enum in the Admin itself? 

> Client Public API should not have PB objects in 2.0
> ---------------------------------------------------
>
>                 Key: HBASE-15174
>                 URL: https://issues.apache.org/jira/browse/HBASE-15174
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira. 
> We have leaked some PB structs in Admin (and possible other places). 
> We should clean up these API before 2.0.
> Examples include: 
> {code}
>   AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final TableName
tableName)
>     throws IOException;
>    
>     ....
>   void snapshot(final String snapshotName,
>       final TableName tableName,
>       HBaseProtos.SnapshotDescription.Type type) throws IOException, SnapshotCreationException,
>       IllegalArgumentException;
>    ....
>   MasterProtos.SnapshotResponse takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
>       throws IOException, SnapshotCreationException;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message