hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15174) Client Public API should not have PB objects in 2.0
Date Wed, 06 Apr 2016 17:51:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228735#comment-15228735
] 

Enis Soztutar commented on HBASE-15174:
---------------------------------------

Great list. Most of these can be addressed with relative ease. 
 - All convert methods, ex. {{org.apache.hadoop.hbase.ClusterStatus convert()}} can go to
ProtobufUtil, so that they are not part of the public API.
 - HConnection itself is deprecated. Maybe we should remove it in 2.0? If not, we can remove
those methods and make them part of ClusterConnection if needed. 
 - Snapshot descriptor / type should be top level POJO classes that correspond to PB structures.



> Client Public API should not have PB objects in 2.0
> ---------------------------------------------------
>
>                 Key: HBASE-15174
>                 URL: https://issues.apache.org/jira/browse/HBASE-15174
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Blocker
>             Fix For: 2.0.0
>
>
> Some more cleanup for the parent jira. 
> We have leaked some PB structs in Admin (and possible other places). 
> We should clean up these API before 2.0.
> Examples include: 
> {code}
>   AdminProtos.GetRegionInfoResponse.CompactionState getCompactionState(final TableName
tableName)
>     throws IOException;
>    
>     ....
>   void snapshot(final String snapshotName,
>       final TableName tableName,
>       HBaseProtos.SnapshotDescription.Type type) throws IOException, SnapshotCreationException,
>       IllegalArgumentException;
>    ....
>   MasterProtos.SnapshotResponse takeSnapshotAsync(HBaseProtos.SnapshotDescription snapshot)
>       throws IOException, SnapshotCreationException;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message