hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-15093) Replication can report incorrect size of log queue for the global source when multiwal is enabled
Date Mon, 11 Apr 2016 15:28:25 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ted Yu updated HBASE-15093:
---------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 1.4.0
                   1.3.0
                   2.0.0
           Status: Resolved  (was: Patch Available)

Thanks for the patch, Ashu.

Thanks for the review, Enis.

> Replication can report incorrect size of log queue for the global source when multiwal
is enabled
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15093
>                 URL: https://issues.apache.org/jira/browse/HBASE-15093
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.2.1
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-15093-V0.patch, HBASE-15093-V1.patch, HBASE-15093-V1.patch,
HBASE-15093-V2.patch
>
>
> Replication can  report incorrect size for the size of log queue for the global source
when multiwal is enabled. This happens because the method MetricsSource#setSizeofLogQueue
performs non-trivial operations in a multithreaded world, even though it is not synchronized.

> We can simply divide MetricsSource#setSizeofLogQueue into MetricsSource#incrSizeofLogQueue
and MetricsSource#decrSizeofLogQueue. Not sure why we are currently directly setting the size
instead of incrementing/decrementing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message