hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14985) TimeRange constructors should set allTime when appropriate
Date Wed, 13 Apr 2016 17:30:26 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239655#comment-15239655
] 

Hudson commented on HBASE-14985:
--------------------------------

FAILURE: Integrated in HBase-0.98-matrix #328 (See [https://builds.apache.org/job/HBase-0.98-matrix/328/])
HBASE-14985 TimeRange constructors should set allTime when appropriate (apurtell: rev a0d13882676d638191a4c7c77fadeb050c4a7e45)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/TimeRangeTracker.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestTimeRangeTracker.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/io/TimeRange.java


> TimeRange constructors should set allTime when appropriate
> ----------------------------------------------------------
>
>                 Key: HBASE-14985
>                 URL: https://issues.apache.org/jira/browse/HBASE-14985
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.2.0, 1.1.3, 0.98.17
>            Reporter: Geoffrey Jacoby
>            Assignee: Geoffrey Jacoby
>            Priority: Minor
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: HBASE-14985-v1.patch, HBASE-14985-v1.patch, HBASE-14985.patch
>
>
> The default TimeRange constructor creates a range from 0 to Long.MAX_VALUE and sets an
allTime flag to true. This flag allows some performance optimizations when comparing or using
TimeRanges.
> This flag is not set, however, if you call "new TimeRange(0L)" or "new TimeRange(0L,
Long.MAX_VALUE)", even though both of these create a logically equivalent TimeRange to "new
TimeRange()". Since TimeRanges are immutable and detecting this condition is trivial, we should
set the flag automatically in the explicit constructors when appropriate. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message