Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7400A1966E for ; Wed, 30 Mar 2016 15:25:26 +0000 (UTC) Received: (qmail 23147 invoked by uid 500); 30 Mar 2016 15:25:26 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 23087 invoked by uid 500); 30 Mar 2016 15:25:26 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 23001 invoked by uid 99); 30 Mar 2016 15:25:26 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Mar 2016 15:25:26 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E2CFE2C1F5C for ; Wed, 30 Mar 2016 15:25:25 +0000 (UTC) Date: Wed, 30 Mar 2016 15:25:25 +0000 (UTC) From: "Sean Busbey (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15563) 'counter' may overflow in BoundedGroupingStrategy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HBASE-15563: -------------------------------- Component/s: wal > 'counter' may overflow in BoundedGroupingStrategy > ------------------------------------------------- > > Key: HBASE-15563 > URL: https://issues.apache.org/jira/browse/HBASE-15563 > Project: HBase > Issue Type: Bug > Components: wal > Reporter: Duo Zhang > Priority: Minor > Labels: beginner > > {code} > groupName = groupNames[counter.getAndIncrement() % groupNames.length]; > {code} > Theoretically, counter can overflow and becomes negative then causes an ArrayIndexOutOfBoundsException. > But in practice, we need 2 billions different identifiers to make this happen, and before the overflow we will run into OOM because of a huge groupNameCache... > So not sure if it is worth to fix -- This message was sent by Atlassian JIRA (v6.3.4#6332)