Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2AB9C18524 for ; Mon, 21 Mar 2016 07:28:26 +0000 (UTC) Received: (qmail 68984 invoked by uid 500); 21 Mar 2016 07:28:26 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 68929 invoked by uid 500); 21 Mar 2016 07:28:26 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 68816 invoked by uid 99); 21 Mar 2016 07:28:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Mar 2016 07:28:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 93CBD2C1F5D for ; Mon, 21 Mar 2016 07:28:25 +0000 (UTC) Date: Mon, 21 Mar 2016 07:28:25 +0000 (UTC) From: "Mikhail Antonov (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15490) Remove duplicated CompactionThroughputControllerFactory in branch-1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203854#comment-15203854 ] Mikhail Antonov commented on HBASE-15490: ----------------------------------------- Thanks for the fix [~carp84]! Yeah, I'm planning to start stabilizing branch 1.3 in a week or two, and fixes and cleanups are always welcome :) > Remove duplicated CompactionThroughputControllerFactory in branch-1 > ------------------------------------------------------------------- > > Key: HBASE-15490 > URL: https://issues.apache.org/jira/browse/HBASE-15490 > Project: HBase > Issue Type: Bug > Affects Versions: 1.3.0 > Reporter: Yu Li > Assignee: Yu Li > Fix For: 1.3.0 > > Attachments: HBASE-15490.branch-1.patch, HBASE-15490.patch > > > Currently there're two {{CompactionThroughputControllerFactory}} in our branch-1 code base (one in {{o.a.h.h.regionserver.compactions}} package, the other in {{o.a.h.h.regionserver.throttle}}) and both are in use. > This is a regression of HBASE-14969 and only exists in branch-1. We should remove the one in {{o.a.h.h.regionserver.compactions}}, and change the default compaction throughput controller back to {{NoLimitThroughputController}} to keep compatible with previous branch-1 version > Thanks [~ghelmling] for pointing out the issue. -- This message was sent by Atlassian JIRA (v6.3.4#6332)