Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0D49B195BE for ; Thu, 17 Mar 2016 01:40:34 +0000 (UTC) Received: (qmail 85416 invoked by uid 500); 17 Mar 2016 01:40:33 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 85367 invoked by uid 500); 17 Mar 2016 01:40:33 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 85351 invoked by uid 99); 17 Mar 2016 01:40:33 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Mar 2016 01:40:33 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7B1ED2C1F54 for ; Thu, 17 Mar 2016 01:40:33 +0000 (UTC) Date: Thu, 17 Mar 2016 01:40:33 +0000 (UTC) From: "Allan Yang (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15474) Exception in HConnectionImplementation's constructor cause Zookeeper connnections leak MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allan Yang updated HBASE-15474: ------------------------------- Attachment: HBASE-15474.patch patch > Exception in HConnectionImplementation's constructor cause Zookeeper connnections leak > --------------------------------------------------------------------------------------- > > Key: HBASE-15474 > URL: https://issues.apache.org/jira/browse/HBASE-15474 > Project: HBase > Issue Type: Bug > Affects Versions: 1.1.0 > Reporter: Allan Yang > Assignee: Allan Yang > Labels: patch > Fix For: 1.1.0 > > Attachments: HBASE-15474.patch > > > HConnectionImplementation creates a ZooKeeperKeepAliveConnection during construction, but if the constructor throw a exception, the zookeeper connection is not properly closed. > {code} > HConnectionImplementation(Configuration conf, boolean managed, > ExecutorService pool, User user) throws IOException { > this(conf); > this.user = user; > this.batchPool = pool; > this.managed = managed; > this.registry = setupRegistry(); > retrieveClusterId(); //here is the zookeeper connection created > this.rpcClient = RpcClientFactory.createClient(this.conf, this.clusterId); > this.rpcControllerFactory = RpcControllerFactory.instantiate(conf);// In our case, the exception happens here, so the zookeeper connection never close > ...... > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)