Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 18 Mar 2016 04:28:33 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12949984.1457978384000.56667.1458275313566@Atlassian.JIRA>
In-Reply-To: <JIRA.12949984.1457978384000@Atlassian.JIRA>
References: <JIRA.12949984.1457978384000@Atlassian.JIRA>
 <JIRA.12949984.1457978384517@arcas>
Subject: [jira] [Commented] (HBASE-15456)
 CreateTableProcedure/ModifyTableProcedure needs to fail when there is no
 family in table descriptor
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-15456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200995#comment-15200995 ] 

Hudson commented on HBASE-15456:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #787 (See [https://builds.apache.org/job/HBase-Trunk_matrix/787/])
HBASE-15456 Revert due to unit test failure in thrift module (tedyu: rev 8c031e9d6b39d9e385bc545215efc73a3cd6d199)
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/namespace/TestNamespaceAuditor.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestModifyTableProcedure.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/CreateTableProcedure.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestRegionMover.java


> CreateTableProcedure/ModifyTableProcedure needs to fail when there is no family in table descriptor
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15456
>                 URL: https://issues.apache.org/jira/browse/HBASE-15456
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 2.0.0
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-15456-001_branch-1.patch, HBASE-15456-branch-1.patch, HBASE-15456-branch-1.patch, HBASE-15456-v001.patch, HBASE-15456-v002.patch, HBASE-15456-v002.patch, HBASE-15456-v003.patch
>
>
> If there is only one family in the table, DeleteColumnFamilyProcedure will fail. 
> Currently, when hbase.table.sanity.checks is set to false, hbase master logs a warning and CreateTableProcedure/ModifyTableProcedure will succeed. 
> This behavior is not consistent with DeleteColumnFamilyProcedure's. 
> Another point, before HBASE-13145, PeriodicMemstoreFlusher will run into the following exception. lastStoreFlushTimeMap is populated for families, if there is no family in the table, there is no entry in lastStoreFlushTimeMap.
> {code}
> 16/02/01 11:14:26 ERROR regionserver.HRegionServer$PeriodicMemstoreFlusher: Caught exception 
> java.util.NoSuchElementException 
> at java.util.concurrent.ConcurrentHashMap$HashIterator.nextEntry(ConcurrentHashMap.java:1354) 
> at java.util.concurrent.ConcurrentHashMap$ValueIterator.next(ConcurrentHashMap.java:1384) 
> at java.util.Collections.min(Collections.java:628) 
> at org.apache.hadoop.hbase.regionserver.HRegion.getEarliestFlushTimeForAllStores(HRegion.java:1572) 
> at org.apache.hadoop.hbase.regionserver.HRegion.shouldFlush(HRegion.java:1904) 
> at org.apache.hadoop.hbase.regionserver.HRegionServer$PeriodicMemstoreFlusher.chore(HRegionServer.java:1509) 
> at org.apache.hadoop.hbase.Chore.run(Chore.java:87) 
> at java.lang.Thread.run(Thread.java:745) 
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)