Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 10 Mar 2016 01:52:40 +0000 (UTC)
From: "Enis Soztutar (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12948593.1457565515000.53662.1457574760738@Atlassian.JIRA>
In-Reply-To: <JIRA.12948593.1457565515000@Atlassian.JIRA>
References: <JIRA.12948593.1457565515000@Atlassian.JIRA>
 <JIRA.12948593.1457565515801@arcas>
Subject: [jira] [Commented] (HBASE-15437) Response size calculated in
 RPCServer for warning tooLarge responses does count CellScanner payload
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-15437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15188481#comment-15188481 ] 

Enis Soztutar commented on HBASE-15437:
---------------------------------------

Not just the log warn, we are also not computing the response size metric correctly: 
{code}
      metrics.sentResponse(responseSize);
{code}

The correct size of the response can be obtained after call.setResponse() is called, because the cells would already been encoded in the buffers in the call.response buffer chain. 

> Response size calculated in RPCServer for warning tooLarge responses does count CellScanner payload
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15437
>                 URL: https://issues.apache.org/jira/browse/HBASE-15437
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC
>            Reporter: deepankar
>
> After HBASE-13158 where we respond back to RPCs with cells in the payload , the protobuf response will just have the count the cells to read from payload, but there are set of features where we log warn in RPCServer whenever the response is tooLarge, but this size now is not considering the sizes of the cells in the PayloadCellScanner. Code form RPCServer
> {code}
>       long responseSize = result.getSerializedSize();
>       // log any RPC responses that are slower than the configured warn
>       // response time or larger than configured warning size
>       boolean tooSlow = (processingTime > warnResponseTime && warnResponseTime > -1);
>       boolean tooLarge = (responseSize > warnResponseSize && warnResponseSize > -1);
>       if (tooSlow || tooLarge) {
>         // when tagging, we let TooLarge trump TooSmall to keep output simple
>         // note that large responses will often also be slow.
>         logResponse(new Object[]{param},
>             md.getName(), md.getName() + "(" + param.getClass().getName() + ")",
>             (tooLarge ? "TooLarge" : "TooSlow"),
>             status.getClient(), startTime, processingTime, qTime,
>             responseSize);
>       }
> {code}
> Should this feature be not supported any more or should we add a method to CellScanner or a new interface which returns the serialized size (but this might not include the compression codecs which might be used during response ?) Any other Idea this could be fixed ?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)