Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 15 Mar 2016 06:16:33 +0000 (UTC)
From: "Ashish Singhi (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12948379.1457523846000.17380.1458022593539@Atlassian.JIRA>
In-Reply-To: <JIRA.12948379.1457523846000@Atlassian.JIRA>
References: <JIRA.12948379.1457523846000@Atlassian.JIRA>
 <JIRA.12948379.1457523846392@arcas>
Subject: [jira] [Commented] (HBASE-15433) SnapshotManager#restoreSnapshot
 not update table and region count quota correctly when encountering
 exception
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15194785#comment-15194785 ] 

Ashish Singhi commented on HBASE-15433:
---------------------------------------

Your idea sounds good to me.

{quote}
4. clientA firstly reset the region count to 5, and then clientB reset the region count to 8, so the final region count for the table is 8 in such case, but it should be 5 because both operations failed.
{quote}
Just a another thought in my mind, instead of getting {{tableRegionCount}} value from quota cache can we get it from RegionLocator by this we can solve these problem. WDYT ?

> SnapshotManager#restoreSnapshot not update table and region count quota correctly when encountering exception
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15433
>                 URL: https://issues.apache.org/jira/browse/HBASE-15433
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0
>            Reporter: Jianwei Cui
>         Attachments: HBASE-15433-trunk-v1.patch, HBASE-15433-trunk-v2.patch, HBASE-15433-trunk.patch
>
>
> In SnapshotManager#restoreSnapshot, the table and region quota will be checked and updated as:
> {code}
>       try {
>         // Table already exist. Check and update the region quota for this table namespace
>         checkAndUpdateNamespaceRegionQuota(manifest, tableName);
>         restoreSnapshot(snapshot, snapshotTableDesc);
>       } catch (IOException e) {
>         this.master.getMasterQuotaManager().removeTableFromNamespaceQuota(tableName);
>         LOG.error("Exception occurred while restoring the snapshot " + snapshot.getName()
>             + " as table " + tableName.getNameAsString(), e);
>         throw e;
>       }
> {code}
> The 'checkAndUpdateNamespaceRegionQuota' will fail if regions in the snapshot make the region count quota exceeded, then, the table will be removed in the 'catch' block. This will make the current table count and region count decrease, following table creation or region split will succeed even if the actual quota is exceeded.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)