Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C33F1950C for ; Wed, 16 Mar 2016 01:31:34 +0000 (UTC) Received: (qmail 7211 invoked by uid 500); 16 Mar 2016 01:31:33 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 7142 invoked by uid 500); 16 Mar 2016 01:31:33 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 6852 invoked by uid 99); 16 Mar 2016 01:31:33 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 16 Mar 2016 01:31:33 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 959E52C1F64 for ; Wed, 16 Mar 2016 01:31:33 +0000 (UTC) Date: Wed, 16 Mar 2016 01:31:33 +0000 (UTC) From: "Hudson (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15377) Per-RS Get metric is time based, per-region metric is size-based MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15196591#comment-15196591 ] Hudson commented on HBASE-15377: -------------------------------- FAILURE: Integrated in HBase-Trunk_matrix #779 (See [https://builds.apache.org/job/HBase-Trunk_matrix/779/]) HBASE-15377 Per-RS Get metric is time based, per-region metric is (enis: rev 51259fe4a5357fadbd4b031c924c965951b3b7cf) * hbase-hadoop2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerSource.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSource.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionServerMetrics.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegion.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > Per-RS Get metric is time based, per-region metric is size-based > ---------------------------------------------------------------- > > Key: HBASE-15377 > URL: https://issues.apache.org/jira/browse/HBASE-15377 > Project: HBase > Issue Type: Sub-task > Reporter: Enis Soztutar > Assignee: Heng Chen > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: HBASE-15377.patch, HBASE-15377_v1.patch, HBASE-15377_v2.patch, HBASE-15377_v2.patch, HBASE-15377_v2.patch > > > We have metrics for Get operations at the region server level and region level. > {code} > "Get_num_ops" : 4837505, > "Get_min" : 0, > "Get_max" : 296, > "Get_mean" : 0.2934618155433431, > "Get_median" : 0.0, > "Get_75th_percentile" : 0.0, > "Get_95th_percentile" : 1.0, > "Get_99th_percentile" : 1.0, > {code} > and > {code} > "Namespace_hbase_table_meta_region_1588230740_metric_get_num_ops" : 103, > "Namespace_hbase_table_meta_region_1588230740_metric_get_min" : 450, > "Namespace_hbase_table_meta_region_1588230740_metric_get_max" : 470, > "Namespace_hbase_table_meta_region_1588230740_metric_get_mean" : 450.19417475728153, > "Namespace_hbase_table_meta_region_1588230740_metric_get_median" : 460.0, > "Namespace_hbase_table_meta_region_1588230740_metric_get_75th_percentile" : 470.0, > "Namespace_hbase_table_meta_region_1588230740_metric_get_95th_percentile" : 470.0, > "Namespace_hbase_table_meta_region_1588230740_metric_get_99th_percentile" : 470.0, > {code} > The problem is that the report values for the region server shows the latency, versus the reported values for the region shows the response sizes. There is no way of telling this without reading the source code. > I think we should deprecate response size histograms in favor of latency histograms. > See also HBASE-15376. -- This message was sent by Atlassian JIRA (v6.3.4#6332)