Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 15 Mar 2016 17:18:33 +0000 (UTC)
From: "Gary Helmling (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12915028.1448062551000.24666.1458062313583@Atlassian.JIRA>
In-Reply-To: <JIRA.12915028.1448062551000@Atlassian.JIRA>
References: <JIRA.12915028.1448062551000@Atlassian.JIRA>
 <JIRA.12915028.1448062551389@arcas>
Subject: [jira] [Commented] (HBASE-14866) VerifyReplication should use peer
 configuration in peer connection
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-14866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195695#comment-15195695 ] 

Gary Helmling commented on HBASE-14866:
---------------------------------------

bq. Doesn't hbase ensure API compatibility across minor version changes without having to recompile?

As Andy mentions, we don't guarantee binary compatibility across minor releases.

Since configuration keys are part of the "job spec" for map reduce, though, you could argue that this falls more under the umbrella of wire format compatibility or even data format compatibility for config keys that have changed.  However, I don't see where the value of OUTPUT_TABLE changed with this patch.  I believe I left it the same because of compatibility concerns.  Maybe I missed something.  

[~haridsv], could it be the setting for QUORUM_ADDRESS or another config tripping you up? Do you have a test case that reproduces the issue you're seeing?  If so, can you open a new JIRA with the test case attached?

> VerifyReplication should use peer configuration in peer connection
> ------------------------------------------------------------------
>
>                 Key: HBASE-14866
>                 URL: https://issues.apache.org/jira/browse/HBASE-14866
>             Project: HBase
>          Issue Type: Improvement
>          Components: Replication
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 0.98.17
>
>         Attachments: HBASE-14866-0.98.patch, HBASE-14866.patch, HBASE-14866_v1.patch, hbase-14866-branch-1-v1.patch, hbase-14866-v4.patch, hbase-14866-v5.patch, hbase-14866-v6.patch, hbase-14866_v2.patch, hbase-14866_v3.patch
>
>
> VerifyReplication uses the replication peer's configuration to construct the ZooKeeper quorum address for the peer connection.  However, other configuration properties in the peer's configuration are dropped.  It should merge all configuration properties from the {{ReplicationPeerConfig}} when creating the peer connection and obtaining a credentials for the peer cluster.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)