Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3633A18F2C for ; Sat, 5 Mar 2016 19:37:41 +0000 (UTC) Received: (qmail 80450 invoked by uid 500); 5 Mar 2016 19:37:41 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 80392 invoked by uid 500); 5 Mar 2016 19:37:41 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 80374 invoked by uid 99); 5 Mar 2016 19:37:41 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Mar 2016 19:37:41 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id AC5AA2C1F56 for ; Sat, 5 Mar 2016 19:37:40 +0000 (UTC) Date: Sat, 5 Mar 2016 19:37:40 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14703) HTable.mutateRow does not collect stats MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15181830#comment-15181830 ] Andrew Purtell commented on HBASE-14703: ---------------------------------------- In 0.98 please. We are evolving the client pushback feature there. Thanks. > HTable.mutateRow does not collect stats > --------------------------------------- > > Key: HBASE-14703 > URL: https://issues.apache.org/jira/browse/HBASE-14703 > Project: HBase > Issue Type: Bug > Reporter: Heng Chen > Assignee: Heng Chen > Fix For: 2.0.0 > > Attachments: HBASE-14702_v5.2_addendum-addendum.patch, HBASE-14703-5.2-addendum.patch, HBASE-14703-async.patch, HBASE-14703-start.patch, HBASE-14703-v4.1.patch, HBASE-14703-v4.patch, HBASE-14703-v6_with-check-and-mutate.patch, HBASE-14703.patch, HBASE-14703_v1.patch, HBASE-14703_v10.patch, HBASE-14703_v10.patch, HBASE-14703_v11.patch, HBASE-14703_v12.patch, HBASE-14703_v13.patch, HBASE-14703_v2.patch, HBASE-14703_v3.patch, HBASE-14703_v5.1.patch, HBASE-14703_v5.2.patch, HBASE-14703_v5.patch, HBASE-14703_v6-addendum.patch, HBASE-14703_v6.patch, HBASE-14703_v7.patch, HBASE-14703_v8.patch, HBASE-14703_v9.patch > > > We are trying to fix the stats implementation, by moving it out of the Result object and into an Rpc payload (but not the 'cell payload', just as part of the values returned from the request). This change will also us use easily switch to AsyncProcess as the executor, and support stats, for nearly all the rpc calls. However, that means when you upgrade the client or server, you will lose stats visibility until the other side is upgraded. We could keep around the Result based stats storage to accommodate the old api and send both stats back from the server (in each result and in the rpc payload). > Note that we will still be wire compatible - protobufs mean we can just ride over the lack of information. > The other tricky part of this is that Result has a non-InterfaceAudience.Private getStatistics() method (along with two InterfaceAudience.Private addResults and setStatistics methods), so we might need a release to deprecate the getStats() method before throwing it out? -- This message was sent by Atlassian JIRA (v6.3.4#6332)