Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 23 Mar 2016 23:13:25 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12834145.1433136444000.35607.1458774805505@Atlassian.JIRA>
In-Reply-To: <JIRA.12834145.1433136444000@Atlassian.JIRA>
References: <JIRA.12834145.1433136444000@Atlassian.JIRA>
 <JIRA.12834145.1433136444544@arcas>
Subject: [jira] [Commented] (HBASE-13819) Make RPC layer CellBlock buffer a
 DirectByteBuffer
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-13819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209388#comment-15209388 ] 

stack commented on HBASE-13819:
-------------------------------

Which Q we talking?  The is config to put bounds on the call queue where we will reject calls... 

bq. The case is row reads. So normally the response size is much lesser than this 512 KB. Still we reserve those many for each of the BB.

Yeah, there is heuristic and we grow till we hit an average. Are we saying we grew to 512k and then afterward, all calls were 16k only? Is this a problem?

Yeah, I like the idea for the BBBP made of fixed-size BBs. Move the code for BucketCache out here.


> Make RPC layer CellBlock buffer a DirectByteBuffer
> --------------------------------------------------
>
>                 Key: HBASE-13819
>                 URL: https://issues.apache.org/jira/browse/HBASE-13819
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-13819.patch, HBASE-13819_branch-1.patch, HBASE-13819_branch-1.patch, HBASE-13819_branch-1.patch
>
>
> In RPC layer, when we make a cellBlock to put as RPC payload, we will make an on heap byte buffer (via BoundedByteBufferPool). The pool will keep upto certain number of buffers. This jira aims at testing possibility for making this buffers off heap ones. (DBB)  The advantages
> 1. Unsafe based writes to off heap is faster than that to on heap. Now we are not using unsafe based writes at all. Even if we add, DBB will be better
> 2. When Cells are backed by off heap (HBASE-11425) off heap to off heap writes will be better
> 3. When checked the code in SocketChannel impl, if we pass a HeapByteBuffer to the socket channel, it will create a temp DBB and copy data to there and only DBBs will be moved to Sockets. If we make DBB 1st hand itself, we can  avoid this one more level of copying.
> Will do different perf testing with changed and report back.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)