hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15512) Avoid cell allocation on Store.add(Cell)
Date Tue, 22 Mar 2016 20:41:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207251#comment-15207251
] 

Enis Soztutar commented on HBASE-15512:
---------------------------------------

Agreed with the reason to clone the actual backing byte[]. Reusing the KV object itself should
be fine as long as we make sure to reset every field. 

Today, the in RPC Cells are encoded with KVCodec and they also use KV in the memstore, so
this patch saves us on current state. However, in the future, we may do different encodings
at the RPC layer versus memstore, so an actual copy may still be needed with different encodings.


> Avoid cell allocation on Store.add(Cell)
> ----------------------------------------
>
>                 Key: HBASE-15512
>                 URL: https://issues.apache.org/jira/browse/HBASE-15512
>             Project: HBase
>          Issue Type: Improvement
>          Components: Performance
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>         Attachments: HBASE-15512-v1.patch, HBASE-15512-v2.patch
>
>
> AbstractMemStore.add(Cell) clones the cell. No reason for that.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message