hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15509) Avoid copy of block data in HFileBlock$Writer.finishBlock
Date Tue, 22 Mar 2016 04:40:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205778#comment-15205778
] 

stack commented on HBASE-15509:
-------------------------------

It says in code:

      // This does an array copy, so it is safe to cache this byte array when cache-on-write.
      // Header is still the empty, 'dummy' header that is yet to be filled out.

So perhaps, if we are not doing cache-on-write, we don't need to allocate at all?

Could try putting in place the BoundedByteBufferPool here? Could then easily have the pool
be offheap.

> Avoid copy of block data in HFileBlock$Writer.finishBlock
> ---------------------------------------------------------
>
>                 Key: HBASE-15509
>                 URL: https://issues.apache.org/jira/browse/HBASE-15509
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>
> This calls ByteArrayOutputStream.toByteArray() which creates a copy of data block. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message