hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15495) Connection leak in FanOutOneBlockAsyncDFSOutputHelper
Date Mon, 21 Mar 2016 18:32:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204826#comment-15204826
] 

stack commented on HBASE-15495:
-------------------------------

+1 on patch after addressing above failures. In tests, rather than add explicit timeouts,
do:

 66 +  // Rather than put a @Test (timeout=.... on each test so for sure the test times out,
instead
 67 +  // just the CategoryBasedTimeout... It will apply to each test in this test set, the
timeout
 68 +  // that goes w/ the particular test categorization.
 69 +  @Rule public final TestRule timeout = CategoryBasedTimeout.builder().withTimeout(this.getClass()).
 70 +        withLookingForStuckThread(true).build();

... up at the top of your test...

To be sure, this path is safe?

223	      Path f = new Path("/test");

It is in HDFS, not at top-level of your machine?

> Connection leak in FanOutOneBlockAsyncDFSOutputHelper
> -----------------------------------------------------
>
>                 Key: HBASE-15495
>                 URL: https://issues.apache.org/jira/browse/HBASE-15495
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>         Attachments: HBASE-15495-v1.patch, HBASE-15495.patch
>
>
> Happens when connecting to datanode failed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message