hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15491) Reuse byte buffers in AsyncRpcClient
Date Mon, 21 Mar 2016 05:30:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15203742#comment-15203742
] 

Anoop Sam John commented on HBASE-15491:
----------------------------------------

I mean, I could see within IPCUtil itself , there is a call to putBuffer in BBBPool. Why?
 Can we make it such that the put back call is in one place? WHere u got it from pool?

Why I asked abt the GC issue is,  we were doing some PoC for reusing the pooled BBs fro reading
the reqs in RpcServer.  Ya can see that it reduced the GC frequency.  But the GC pause time
is larger. (I mean the young gen GC)..  So I was asking whether u also see any such pattern
after this BB reuse change

> Reuse byte buffers in AsyncRpcClient
> ------------------------------------
>
>                 Key: HBASE-15491
>                 URL: https://issues.apache.org/jira/browse/HBASE-15491
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>    Affects Versions: 2.0.0
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15491-v1.patch
>
>
> IPCUtil.buildCellBlock is used by both server and client. Server provides BoundedByteBufferPool
for buffers reuse, client code does not do that. This results in additional memory pressure
on a client side, because buffers are allocated on every call to IPCUtil.buildCellBlock.
> My own local tests (with patch) show approximately 8-10% reduction in object allocation
rate on a client side (with HBASE-15479 as well). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message