hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15485) Filter.reset() should not be called between batches
Date Thu, 31 Mar 2016 05:05:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219352#comment-15219352
] 

ramkrishna.s.vasudevan commented on HBASE-15485:
------------------------------------------------

bq.When batched read happening and batch size is say 5 and one row is having 5 cells in it,
which state we will be in? Whether we will call filter rest then also correctly? Add a test?
This is a very good comment. 
bq.I think it will be BATCH_LIMIT_REACHED in your scene rather than MORE_VALUES.
I think it will be BATCH_LIMIT_REACHED right? I don't think before saying BATCH_LIMIT_REACHED
we check for the next cell. 
bq.We will get NO_MORE_VALUES iff the scan is finishing?
I think yes, ony when the stopRow is reached I think.

> Filter.reset() should not be called between batches
> ---------------------------------------------------
>
>                 Key: HBASE-15485
>                 URL: https://issues.apache.org/jira/browse/HBASE-15485
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: HBASE-15485-v1.patch
>
>
> As discussed in HBASE-15325, now we will resetFilters if partial result not formed, but
we should not reset filters when batch limit reached



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message