hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15477) Do not save 'next block header' when we cache hfileblocks
Date Thu, 17 Mar 2016 23:14:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200600#comment-15200600
] 

Hadoop QA commented on HBASE-15477:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 11 new or modified test files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue}
Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 53s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 45s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 12s {color} |
{color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m 32s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 18s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 3s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 24s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 6s {color} | {color:green}
master passed with JDK v1.7.0_79 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s {color} | {color:blue}
Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 34s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 33s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 12s {color} | {color:red}
hbase-external-blockcache in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 13s {color} | {color:red}
hbase-external-blockcache in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 47s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 47s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 20s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 20s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 47s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 47s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 20s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 20s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.8.0. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 33s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 32s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 18s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 17s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 33s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 32s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 18s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.7.0_79. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 17s {color} | {color:red}
hbase-external-blockcache in the patch failed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m 46s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m 16s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red}
The patch has 5 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 0m 59s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 54s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 50s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 46s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 42s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 37s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 36s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m 32s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 27s {color} | {color:red}
Patch causes 44 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 20s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 21s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 12s {color} | {color:red}
hbase-external-blockcache in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 13s {color} | {color:red}
hbase-external-blockcache in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 31s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 0s {color} | {color:green}
the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 7s {color} | {color:green}
hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 5s {color} | {color:green}
hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 33s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 32s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 17s {color} | {color:red}
hbase-external-blockcache in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 17s {color} | {color:red}
hbase-external-blockcache in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 44s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 23s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12794082/15477v2.patch
|
| JIRA Issue | HBASE-15477 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / fbf58f3 |
| Default Java | 1.7.0_79 |
| Multi-JDK versions |  /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79
|
| findbugs | v3.0.0 |
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-mvninstall-hbase-server.txt
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-mvninstall-hbase-server.txt
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-mvninstall-hbase-external-blockcache.txt
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-mvninstall-hbase-external-blockcache.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.8.0.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.8.0.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.8.0.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.8.0.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_79.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_79.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.7.0_79.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.7.0_79.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_79.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_79.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.7.0_79.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-compile-hbase-external-blockcache-jdk1.7.0_79.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/whitespace-eol.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-findbugs-hbase-server.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-findbugs-hbase-server.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-findbugs-hbase-external-blockcache.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-findbugs-hbase-external-blockcache.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-unit-hbase-external-blockcache.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/artifact/patchprocess/patch-unit-hbase-external-blockcache.txt
|
|  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/testReport/ |
| modules | C:  hbase-common   hbase-common   hbase-server   hbase-server   hbase-external-blockcache
  hbase-external-blockcache  U: . |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1050/console |
| Powered by | Apache Yetus 0.2.0   http://yetus.apache.org |


This message was automatically generated.



> Do not save 'next block header' when we cache hfileblocks
> ---------------------------------------------------------
>
>                 Key: HBASE-15477
>                 URL: https://issues.apache.org/jira/browse/HBASE-15477
>             Project: HBase
>          Issue Type: Sub-task
>          Components: BlockCache, Performance
>            Reporter: stack
>            Assignee: stack
>         Attachments: 15477.patch, 15477v2.patch
>
>
>     When we read from HDFS, we overread to pick up the next blocks header.
>     Doing this saves a seek as we move through the hfile; we save having to
>     do an explicit seek just to read the block header every time we need to
>     read the body.  We used to read in the next header as part of the
>     current blocks buffer. This buffer was then what got persisted to
>     blockcache; so we were over-persisting wrtiting out our block plus the
>     next blocks' header (overpersisting 33 bytes). Parse of HFileBlock
>     complicated by this extra tail. Fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message