hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jingcheng Du (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15439) getMaximumAllowedTimeBetweenRuns in ScheduledChore ignores the TimeUnit
Date Mon, 14 Mar 2016 05:53:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15192773#comment-15192773
] 

Jingcheng Du commented on HBASE-15439:
--------------------------------------

The method getMaximumAllowedTimeBetweenRuns in ScheduledChore ignores the TimeUnit.
{code}
private synchronized boolean missedStartTime() {
    return isValidTime(timeOfLastRun) && isValidTime(timeOfThisRun)
        && getTimeBetweenRuns() > getMaximumAllowedTimeBetweenRuns();
  }

  private double getMaximumAllowedTimeBetweenRuns() {
    // Threshold used to determine if the Chore's current run started too late
    return 1.5 * period;
  }
{code}
The method getTimeBetweenRuns() uses milliseconds, if period is using another TimeUnit instead
of milliseconds, the chore service will  always miss its start time. We need consider TimeUnit
in the method getMaximumAllowedTimeBetweenRuns().

> getMaximumAllowedTimeBetweenRuns in ScheduledChore ignores the TimeUnit
> -----------------------------------------------------------------------
>
>                 Key: HBASE-15439
>                 URL: https://issues.apache.org/jira/browse/HBASE-15439
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Jingcheng Du
>
> I was running IntegrationTestIngestWithMOB test.
> I lower the mob compaction chore interval to this value:
> {code}
>     <property>
>       <name>hbase.mob.compaction.chore.period</name>
>       <value>6000</value>
>     </property>
> {code}
> After whole night, there was no indication from master log that mob compaction ran.
> All I found was:
> {code}
> 2016-03-09 04:18:52,194 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_1]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 05:58:52,516 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_1]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 07:38:52,847 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_2]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 09:18:52,848 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_1]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 10:58:52,932 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_2]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 12:38:52,932 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_1]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 14:18:52,933 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_2]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 15:58:52,957 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_1]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> 2016-03-09 17:38:52,960 INFO  [tyu-hbase-rhel-re-2.novalocal,20000,1457491115327_ChoreService_2]
hbase.ScheduledChore: Chore: tyu-hbase-rhel-re-2.novalocal,20000,1457491115327-  MobCompactionChore
missed its start time
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message