hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HBASE-15433) SnapshotManager#restoreSnapshot not update table and region count quota correctly when encountering exception
Date Fri, 18 Mar 2016 12:47:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201414#comment-15201414
] 

Ted Yu edited comment on HBASE-15433 at 3/18/16 12:46 PM:
----------------------------------------------------------

Jianwei:
I looked at the scenario (region counts of 8 and 10 in snapshots) above where retrieving from
region locator may produce inaccurate end result.

We can go with patch v4.

Since branch-1 is among the Fix versions, can you attach patch for branch-1 ? branch-1 tests
are more stable, hopefully we can get higher confidence.

Thanks


was (Author: yuzhihong@gmail.com):
Jianwei:
I looked at the scenario (region counts of 8 and 10 in snapshots) above where retrieving from
region locator may produce inaccurate end result.

We can go with path v4.

Since branch-1 is among the Fix versions, can you attach patch for branch-1 ? branch-1 tests
are more stable, hopefully we can get higher confidence.

Thanks

> SnapshotManager#restoreSnapshot not update table and region count quota correctly when
encountering exception
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15433
>                 URL: https://issues.apache.org/jira/browse/HBASE-15433
>             Project: HBase
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 2.0.0
>            Reporter: Jianwei Cui
>            Assignee: Jianwei Cui
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.4.0, 1.1.5
>
>         Attachments: HBASE-15433-trunk-v1.patch, HBASE-15433-trunk-v2.patch, HBASE-15433-trunk.patch,
HBASE-15433-v3.patch, HBASE-15433-v4.patch
>
>
> In SnapshotManager#restoreSnapshot, the table and region quota will be checked and updated
as:
> {code}
>       try {
>         // Table already exist. Check and update the region quota for this table namespace
>         checkAndUpdateNamespaceRegionQuota(manifest, tableName);
>         restoreSnapshot(snapshot, snapshotTableDesc);
>       } catch (IOException e) {
>         this.master.getMasterQuotaManager().removeTableFromNamespaceQuota(tableName);
>         LOG.error("Exception occurred while restoring the snapshot " + snapshot.getName()
>             + " as table " + tableName.getNameAsString(), e);
>         throw e;
>       }
> {code}
> The 'checkAndUpdateNamespaceRegionQuota' will fail if regions in the snapshot make the
region count quota exceeded, then, the table will be removed in the 'catch' block. This will
make the current table count and region count decrease, following table creation or region
split will succeed even if the actual quota is exceeded.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message