hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15411) Rewrite backup with Procedure V2
Date Fri, 25 Mar 2016 16:31:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212026#comment-15212026
] 

Ted Yu commented on HBASE-15411:
--------------------------------

w.r.t. switching to env.getMasterServices().getSnapshotManager().takeSnapshot(backupSnapshot)
in FullTableBackupProcedure, I want to get clarification on where the waiting logic should
be placed.
Specifically, in HBaseAdmin, we have:
{code}
    LOG.debug("Waiting a max of " + max + " ms for snapshot '" +
        ClientSnapshotDescriptionUtils.toString(snapshot) + "'' to complete. (max " +
        maxPauseTime + " ms per retry)");
    while (tries == 0
        || ((EnvironmentEdgeManager.currentTime() - start) < max && !done.getDone()))
{
{code}
Where should the above waiting logic be placed after the switch to calling getSnapshotManager().takeSnapshot()
?

> Rewrite backup with Procedure V2
> --------------------------------
>
>                 Key: HBASE-15411
>                 URL: https://issues.apache.org/jira/browse/HBASE-15411
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>         Attachments: 15411-v1.txt, 15411-v11.txt, 15411-v12.txt, 15411-v13.txt, 15411-v14.txt,
15411-v15.txt, 15411-v16.txt, 15411-v18.txt, 15411-v22.txt, 15411-v3.txt, 15411-v5.txt, 15411-v6.txt,
15411-v7.txt, 15411-v9.txt, FullTableBackupProcedure.java
>
>
> Currently full / incremental backup is driven by BackupHandler (see call() method for
flow).
> This issue is to rewrite the flow using Procedure V2.
> States (enum) for full / incremental backup would be introduced in Backup.proto which
correspond to the steps performed in BackupHandler#call().
> executeFromState() would pace the backup based on the current state.
> serializeStateData() / deserializeStateData() would be used to persist state into procedure
WAL.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message