hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck
Date Fri, 18 Mar 2016 13:30:33 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201469#comment-15201469
] 

Ted Yu commented on HBASE-15406:
--------------------------------

{code}
4283	      ZKUtil.createSetData(zkw,  splitOrMergeLock,
4284	        ProtobufUtil.prependPBMagic(builder.build().toByteArray()));
{code}
How about calling createEphemeralNodeAndWatch() in the above ?
Protection against changing the switch when hbck is running can be achieved by checking presence
of the lock znode (not its contents).
If hbck dies unexpectedly, the lock znode would disappear.

> Split / merge switch left disabled after early termination of hbck
> ------------------------------------------------------------------
>
>                 Key: HBASE-15406
>                 URL: https://issues.apache.org/jira/browse/HBASE-15406
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-15406.patch, HBASE-15406.v1.patch, HBASE-15406_v1.patch, test.patch,
wip.patch
>
>
> This was what I did on cluster with 1.4.0-SNAPSHOT built Thursday:
> Run 'hbase hbck -disableSplitAndMerge' on gateway node of the cluster
> Terminate hbck early
> Enter hbase shell where I observed:
> {code}
> hbase(main):001:0> splitormerge_enabled 'SPLIT'
> false
> 0 row(s) in 0.3280 seconds
> hbase(main):002:0> splitormerge_enabled 'MERGE'
> false
> 0 row(s) in 0.0070 seconds
> {code}
> Expectation is that the split / merge switches should be restored to default value after
hbck exits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message