hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15406) Split / merge switch left disabled after early termination of hbck
Date Wed, 09 Mar 2016 19:01:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187668#comment-15187668
] 

Ted Yu commented on HBASE-15406:
--------------------------------

{code}
+    if (ZKUtil.checkExists(watcher, splitOrMergeLease) < 0) {
+      throw new RuntimeException("splitOrMerge lease has been acquired!");
{code}
The exception message doesn't match the condition. Did you mean to say 'has to be acquired"
?

Previously setSplitOrMergeEnabled() didn't require lease. With patch, component in master
has to obtain lease before enabling split / merge.
SplitOrMergeLeaseTracker does the rollback. What if master crashes after getting zookeeper
notification but before restoring split / merge states ?

> Split / merge switch left disabled after early termination of hbck
> ------------------------------------------------------------------
>
>                 Key: HBASE-15406
>                 URL: https://issues.apache.org/jira/browse/HBASE-15406
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-15406.v1.patch, wip.patch
>
>
> This was what I did on cluster with 1.4.0-SNAPSHOT built Thursday:
> Run 'hbase hbck -disableSplitAndMerge' on gateway node of the cluster
> Terminate hbck early
> Enter hbase shell where I observed:
> {code}
> hbase(main):001:0> splitormerge_enabled 'SPLIT'
> false
> 0 row(s) in 0.3280 seconds
> hbase(main):002:0> splitormerge_enabled 'MERGE'
> false
> 0 row(s) in 0.0070 seconds
> {code}
> Expectation is that the split / merge switches should be restored to default value after
hbck exits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message