hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15389) Write out multiple files when compaction
Date Thu, 24 Mar 2016 06:07:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209829#comment-15209829
] 

Duo Zhang commented on HBASE-15389:
-----------------------------------

{quote}
Since regression tests didn't find them, could you double check when back-porting the patch?
I am going to do some limited end-to-end testing on 98 on production. Not sure which branch
you will test on. Please let me know.
{quote}
The hbase version of my company is also 0.98 :)

For the getScanType method. In branch-1, there is no retainDeleteMarkers field in CompactionRequest,
so I use request.isAllFiles. This is the same with the DefaultCompactor implementation on
branch-1.
{code}
        ScanType scanType =
            request.isAllFiles() ? ScanType.COMPACT_DROP_DELETES : ScanType.COMPACT_RETAIN_DELETES;
{code}
And for 0.98, there is neither retainDeleteMarkers nor isAllFiles so I use isMajor. The same
with the DefaultCompactor implementation.
{code}
        ScanType scanType =
            request.isMajor() ? ScanType.COMPACT_DROP_DELETES : ScanType.COMPACT_RETAIN_DELETES;
{code}

> Write out multiple files when compaction
> ----------------------------------------
>
>                 Key: HBASE-15389
>                 URL: https://issues.apache.org/jira/browse/HBASE-15389
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>    Affects Versions: 2.0.0, 0.98.19, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 0.98.19, 1.4.0
>
>         Attachments: HBASE-15389-0.98.patch, HBASE-15389-0.98.v1.patch, HBASE-15389-0.98.v2.patch,
HBASE-15389-branch-1.patch, HBASE-15389-uc.patch, HBASE-15389-v1.patch, HBASE-15389-v10.patch,
HBASE-15389-v11.patch, HBASE-15389-v12.patch, HBASE-15389-v13.patch, HBASE-15389-v14.patch,
HBASE-15389-v2.patch, HBASE-15389-v3.patch, HBASE-15389-v4.patch, HBASE-15389-v5.patch, HBASE-15389-v6.patch,
HBASE-15389-v7.patch, HBASE-15389-v8.patch, HBASE-15389-v9.patch, HBASE-15389.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message