hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Clara Xiong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15389) Write out multiple files when compaction
Date Wed, 23 Mar 2016 16:13:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208676#comment-15208676
] 

Clara Xiong commented on HBASE-15389:
-------------------------------------

[~Apache9] Could you update your 98 patch with the latest changes in your master patch before
you check in? 
In you master patch, DateTieredCompactor expects lower boundaries addressing my comments.
In your 98 patch, it expects one extra boundary and removes the last boundary. HBASE-15400
patch was implemented based on the master patch so I am not sending any extra boundaries.
This breaks DTCP on 98.

And there is one more issue found by [~davelatham]:

trunk patch looks correct:
+      public ScanType getScanType(CompactionRequest request) {
+        return request.isRetainDeleteMarkers() ? ScanType.COMPACT_RETAIN_DELETES
+            : ScanType.COMPACT_DROP_DELETES;
+      }

branch-1 patch looks wrong:
+      public ScanType getScanType(CompactionRequest request) {
+        return request.isAllFiles() ? ScanType.COMPACT_RETAIN_DELETES
+            : ScanType.COMPACT_DROP_DELETES;

branch-98 patch looks wrong:
+      public ScanType getScanType(CompactionRequest request) {
+        return request.isMajor() ? ScanType.COMPACT_RETAIN_DELETES : ScanType.COMPACT_DROP_DELETES;
+      }

Since regression tests didn't find them, could you double check when back-porting the patch?
I am going to do some limited end-to-end testing on 98 on production. Not sure which branch
you will test on. Please let me know.

> Write out multiple files when compaction
> ----------------------------------------
>
>                 Key: HBASE-15389
>                 URL: https://issues.apache.org/jira/browse/HBASE-15389
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Compaction
>    Affects Versions: 2.0.0, 0.98.19, 1.4.0
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0, 0.98.19, 1.4.0
>
>         Attachments: HBASE-15389-0.98.patch, HBASE-15389-0.98.v1.patch, HBASE-15389-branch-1.patch,
HBASE-15389-uc.patch, HBASE-15389-v1.patch, HBASE-15389-v10.patch, HBASE-15389-v11.patch,
HBASE-15389-v12.patch, HBASE-15389-v13.patch, HBASE-15389-v14.patch, HBASE-15389-v2.patch,
HBASE-15389-v3.patch, HBASE-15389-v4.patch, HBASE-15389-v5.patch, HBASE-15389-v6.patch, HBASE-15389-v7.patch,
HBASE-15389-v8.patch, HBASE-15389-v9.patch, HBASE-15389.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message