hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15376) ScanNext metric is size-based while every other per-operation metric is time based
Date Wed, 02 Mar 2016 11:02:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175439#comment-15175439
] 

Hadoop QA commented on HBASE-15376:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 55s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 17s {color} |
{color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 10s {color} |
{color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m 39s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 44s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 21s {color} |
{color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 15s {color} |
{color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 14s {color} |
{color:green} master passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 13s {color} | {color:red}
hbase-hadoop2-compat in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 23s {color} |
{color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 23s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 11s {color} |
{color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 11s {color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 17s {color} | {color:red}
Patch generated 1 new checkstyle issues in hbase-hadoop-compat (total was 0, now 1). {color}
|
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 5m 1s {color} | {color:red}
Patch generated 1 new checkstyle issues in hbase-server (total was 140, now 140). {color}
|
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 44s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 32m 7s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 41s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s {color} | {color:green}
the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 5s {color} | {color:green}
the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s {color} | {color:green}
hbase-hadoop2-compat in the patch passed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 21s {color} | {color:green}
hbase-hadoop-compat in the patch passed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 31m 53s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s {color} | {color:green}
hbase-hadoop2-compat in the patch passed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 22s {color} | {color:green}
hbase-hadoop-compat in the patch passed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 33m 43s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 34s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 135m 32s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_72 Failed junit tests | hadoop.hbase.procedure.TestProcedureManager |
|   | hadoop.hbase.mob.mapreduce.TestMobSweepMapper |
|   | hadoop.hbase.master.balancer.TestRegionLocationFinder |
| JDK v1.7.0_95 Failed junit tests | hadoop.hbase.procedure.TestProcedureManager |
|   | hadoop.hbase.mob.mapreduce.TestMobSweepMapper |
|   | hadoop.hbase.master.balancer.TestRegionLocationFinder |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-03-02 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12790888/HBASE-15376.patch
|
| JIRA Issue | HBASE-15376 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux 00da5ff211f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh
|
| git revision | master / dc44943 |
| findbugs | v3.0.0 |
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/796/artifact/patchprocess/patch-mvninstall-hbase-hadoop2-compat.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/796/artifact/patchprocess/diff-checkstyle-hbase-hadoop-compat.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/796/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/796/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/796/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/796/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/796/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
|
| JDK v1.7.0_95  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/796/testReport/
|
| modules | C: hbase-hadoop2-compat hbase-hadoop-compat hbase-server U: . |
| Max memory used | 189MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/796/console |


This message was automatically generated.



> ScanNext metric is size-based while every other per-operation metric is time based
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-15376
>                 URL: https://issues.apache.org/jira/browse/HBASE-15376
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>         Attachments: HBASE-15376.patch
>
>
> We have per-operation metrics for {{Get}}, {{Mutate}}, {{Delete}}, {{Increment}}, and
{{ScanNext}}. 
> The metrics are emitted like: 
> {code}
>    "Get_num_ops" : 4837505,
>     "Get_min" : 0,
>     "Get_max" : 296,
>     "Get_mean" : 0.2934618155433431,
>     "Get_median" : 0.0,
>     "Get_75th_percentile" : 0.0,
>     "Get_95th_percentile" : 1.0,
>     "Get_99th_percentile" : 1.0,
> ...
>     "ScanNext_num_ops" : 194705,
>     "ScanNext_min" : 0,
>     "ScanNext_max" : 18441,
>     "ScanNext_mean" : 7468.274651395701,
>     "ScanNext_median" : 583.0,
>     "ScanNext_75th_percentile" : 583.0,
>     "ScanNext_95th_percentile" : 13481.0,
>     "ScanNext_99th_percentile" : 13481.0,
> {code}
> The problem is that all of Get,Mutate,Delete,Increment,Append,Replay are time based tracking
how long the operation ran, while ScanNext is tracking returned response sizes (returned cell-sizes
to be exact). Obviously, this is very confusing and you would only know this subtlety if you
read the metrics collection code. 
> Not sure how useful is the ScanNext metric as it is today. We can deprecate it, and introduce
a time based one to keep track of scan request latencies. 
> ps. Shamelessly using the parent jira (since these seem relavant). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message