hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15366) Add doc, trace-level logging, and test around hfileblock
Date Tue, 01 Mar 2016 08:04:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15173413#comment-15173413
] 

Hadoop QA commented on HBASE-15366:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 8 new or modified test files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 12s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 56s {color} |
{color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s {color} | {color:green}
master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 5m 37s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 34s {color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 13s {color} | {color:red}
hbase-server in master has 1 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 57s {color} |
{color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s {color} | {color:green}
master passed with JDK v1.7.0_95 {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 42s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 40s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 40s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m 40s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 40s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 31s {color} | {color:red}
Patch generated 4 new checkstyle issues in hbase-server (total was 273, now 274). {color}
|
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 31s {color}
| {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red}
The patch has 4 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 14s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.4.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 2m 21s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.4.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 32s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.5.0. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 42s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.5.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 5m 55s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.5.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m 11s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.6.1. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m 28s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.6.2. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 44s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.6.3. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 59s {color} | {color:red}
Patch causes 24 errors with Hadoop v2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 26s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 52s {color} |
{color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s {color} |
{color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 9s {color} | {color:green}
hbase-common in the patch passed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 40s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 12s {color} | {color:green}
hbase-common in the patch passed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 41s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 47m 42s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-03-01 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12790683/15366.patch |
| JIRA Issue | HBASE-15366 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux d5e9befb40a2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 7c54525 |
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| mvninstall | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-mvninstall-hbase-server.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0_72.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-compile-hbase-server-jdk1.8.0_72.txt
|
| compile | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_95.txt
|
| javac | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-compile-hbase-server-jdk1.7.0_95.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/whitespace-eol.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-findbugs-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/773/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
|
| JDK v1.7.0_95  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/773/testReport/
|
| modules | C: hbase-common hbase-server U: . |
| Max memory used | 187MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/773/console |


This message was automatically generated.



> Add doc, trace-level logging, and test around hfileblock
> --------------------------------------------------------
>
>                 Key: HBASE-15366
>                 URL: https://issues.apache.org/jira/browse/HBASE-15366
>             Project: HBase
>          Issue Type: Sub-task
>          Components: BlockCache
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 2.0.0
>
>         Attachments: 15366.patch
>
>
> What hfileblock is doing -- that it overreads when pulling in from hdfs to fetch the
header of the next block to save on seeks; that it caches the block and overread and then
adds an extra 13 bytes to the cached entry; that buckets in bucketcache have at least four
hfileblocks in them and so on -- was totally baffling me. This patch docs the class, adds
some trace-level logging so you can see if you are doing the right thing, and then adds a
test of file-backed bucketcache that checks that persistence is working.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message